Add outdate, update and upgrade commands #865
Conversation
silvanocerza
added
topic: documentation
silvanocerza
changed the title
silvanocerza
changed the title
test/test_outdated.py
Outdated
| assert run_command("core install arduino:samd") | ||
| assert run_command("lib install ArduinoJson") | ||
|
|
||
| # Verifies only outdate core and library are returned |
There was a problem hiding this comment.
| # Verifies only outdate core and library are returned | |
| # Verifies only outdated cores and libraries are returned |
cli/outdated/outdated.go
Outdated
| func NewCommand() *cobra.Command { | ||
| outdatedCommand := &cobra.Command{ | ||
| Use: "outdated", | ||
| Short: "Lists cores and libraries that can be upgraded\n", |
There was a problem hiding this comment.
| Short: "Lists cores and libraries that can be upgraded\n", | |
| Short: "Lists cores and libraries that can be upgraded", |
This created an empty row in the autocompletion like:
╰─$ ./arduino-cli
board -- Arduino board commands.
burn-bootloader -- Upload the bootloader.
cache -- Arduino cache commands.
compile -- Compiles Arduino sketches.
completion -- Generates completion scripts
config -- Arduino configuration commands.
core -- Arduino core operations.
daemon -- Run as a daemon on port 50051
debug -- Debug Arduino sketches.
help -- Help about any command
lib -- Arduino commands about libraries.
outdated -- Lists cores and libraries that can be upgraded
sketch -- Arduino CLI sketch commands.
update -- Updates the index of cores and libraries
upgrade -- Upgrades installed cores and libraries.
upload -- Upload Arduino sketches.
version -- Shows version number of Arduino CLI.
| } | ||
|
|
||
| logrus.Info("Executing `arduino outdated`") | ||
|
|
There was a problem hiding this comment.
To really see all the outdated cores and libraries, should we launch a commands.UpdateIndex() and a UpdateLibrariesIndex() before checking through the local libs and cores? (this is also a functional question for @ubidefeo 🙂 )
There was a problem hiding this comment.
in Homebrew style this command only returns something after an update, bit I like the idea that it implicitly runs arduino-cli update before running
There was a problem hiding this comment.
I'll change that. 👍
test/test_upgrade.py
Outdated
| assert run_command("core install arduino:samd") | ||
| assert run_command("lib install ArduinoJson") | ||
|
|
||
| assert run_command("upgrade") |
There was a problem hiding this comment.
Might be reasonable to add a double check here like you did in the outdated test, checking if no more stuff to upgrade is present after an upgrade WDYT?
There was a problem hiding this comment.
It's kinda problematic for upgrade since basically all the strings contain the latest versions of libraries and cores being upgraded, can't really hardcode it.
I can check oudated commands output though.
There was a problem hiding this comment.
@silvanocerza and I went through some small cosmetic/usage changes
I tested and it works beautifully
@rsora can you review/approve?
before creating one)
Add three new commands:
outdatedupdateupgradeThose commands don't exist.
What is the new behavior?
arduino-cli outdatedreturns a list of cores and libraries that are outdated, showing the currently installed version and the newly available one.arduino-cli updatedownloads and installs the index for installed cores and libraries if new ones are available.arduino-cli upgradedownloads and installs all available upgrades for installaed cores and libraries.Nope.
None.
See how to contribute